Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aggregation Temporality in Dynatrace Exporter #181

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

KarstenSchnitter
Copy link
Contributor

Dynatrace only accepts "delta" aggregation temporality for counters. The "deltaPreferred" option still uses cumulative temporality for up-and-down-counters. This lets Dynatrace drop the data altogether. This commit will send all counters with delta aggregation temporality.

Dynatrace only accepts "delta" aggregation temporality for counters.
The "deltaPreferred" option still uses cumulative temporality for
up-and-down-counters. This lets Dynatrace drop the data altogether.
This commit will send all counters with delta aggregation temporality.

Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Copy link
Member

@Anika-Sol Anika-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested it with an LongUpDownCounter and was able to the the metrics show up in Dynatrace.
Thank you for implementing this fix.

@nicklas-dohrn nicklas-dohrn self-requested a review July 15, 2024 11:18
Copy link
Contributor

@nicklas-dohrn nicklas-dohrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KarstenSchnitter KarstenSchnitter merged commit 9732fe3 into main Jul 15, 2024
2 checks passed
@KarstenSchnitter KarstenSchnitter deleted the fix-dt-otel-temporality branch July 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants